Implement JSON builder#8
Closed
wouterj wants to merge 1 commit into
Closed
Conversation
22dbe01 to
77ea823
Compare
77ea823 to
3144564
Compare
10 tasks
Owner
Author
|
integrated in symfony-tools/docs-builder#200 |
stof
reviewed
Mar 18, 2026
Contributor
stof
left a comment
There was a problem hiding this comment.
I started a review yesterday that I forgot to submit.
| use phpDocumentor\Guides\Renderer\TypeRenderer; | ||
| use phpDocumentor\Guides\Renderer\UrlGenerator\UrlGeneratorInterface; | ||
|
|
||
| class JsonRenderer implements TypeRenderer |
Contributor
There was a problem hiding this comment.
or maybe JsonHtmlRenderer to be consistent with the Sphinx name
Owner
Author
There was a problem hiding this comment.
The "fun" thing about the phpDocumentor implementation is that the project renderer can be another format than the node renderer. So this class actually doesn't care about the format of the body (except for the page link extensions 🤔 ).
Keeping consistency with the Sphinx name, but decoupling it from Html is exactly how I got to the JsonRenderer name.
Thanks for all your review work btw!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of HTML files, Symfony needs
.fjsonfiles with the following schema: