[toggle-editor] The focus does not work correctly in two cases

[ralf3u]

The shortcut "Toggle editor" of the project toggle-editor (see main page at https://github.com/xiota/geanylua-scripts) has two issues:

1. If Editor has focus and when switching from Editor&Sidebar to only Sidebar, then the content-area of the Preview-tab is not in focus.
2. When switching back from only Sidebar to Editor&Sidebar then the Editor is not in focus.

Remark
If the issue number 82 at xiota/geany-preview/ would be fixed – it is about the shortcut "Toggle only between Editor&Sidebar and Sidebar" –, it could be that some users will not like to change the position of the splitter for the shortcut with the key sidebar_width_shortcut through the preferences of Preview, because for example they change many times a day the position of the splitter.
So, the project toggle-editor at xiota/geanylua-scripts/ is an interesting alternative to issue number 82 at xiota/geany-preview/.

[ralf3u]

I'm not a software developer but for me it looks like toggle-editor has at the moment a little bit too much code and maybe too much files. But maybe I'm wrong.

What the code should do:
IF Editor&Sidebar are visible THEN show only Sidebar and focus on Preview.
IF only Sidebar is visible THEN show Editor&Sidebar and focus on Editor.
And nothing more.

[ralf3u]

What the code should do:
IF Editor&Sidebar are visible THEN show only Sidebar and focus on Preview.
IF only Sidebar is visible THEN show Editor&Sidebar and focus on Editor.
And nothing more.

"Nothing more" means for example:
IF sidebar is disabled THEN do nothing.

[ralf3u]

To my last two comments: If it means too big changes of the project toggle-editor, maybe it would be good to create a new project with a new name, something like: toggle-editor-when-sidebar-is-visible.

[ralf3u]

Disadvantage of the shortcut
There is one big disadvantage when using the shortcut (if the shortcut works like described above):
If the shortcut is pressed 1x and only Sidebar is visible, then one should be aware to press another time 1x the shortcut BEFORE to press other toggle-views shortcuts like the Geany shortcut "Toggle Sidebar", or the Preview shortcut that I like to call "Toggle Sidebar and switch focus to Sidebar", or the two other Preview shortcuts "Toggle only between Editor&Sidebar and Sidebar" and "Toggle only between Editor and Sidebar", otherwise, an empty tab will appear.
This is the only thing that one should keep in mind before pressing the shortcut.

[ralf3u]

Would it be possible to fix this issue in the next weeks?

[ralf3u]

Today I could fix this issue. In the document toggle-functions.lua I added two lines:

In the function editor_hide(), just after the line geany.yield(), I added this line:
geany.keycmd("FOCUS_SIDEBAR")

In the function editor_show(), just after the line geany.yield(), I added this line:
geany.keycmd("FOCUS_EDITOR")

Thank you very much for that script because now it works absolutely perfect!

Could you please update toggle-editor?

[ralf3u]

Could you please update toggle-editor?

And could you please remove unnecessary code and files? The result would be that the code would be easier to understand.