`$customer->markPropertyChanged('');` should mark it changed

[Tigrov]

Perhaps this is a bug and $customer->markPropertyChanged(''); should change it.

Originally posted by @Tigrov in #545 (comment)

[samdark]

@Tigrov what is a property with empty string as a name?

[Tigrov]

The mutant kill test was added

    public function testMarkPropertyChangedWithEmptyNameDoesNotModifyOldValues(): void
    {
        $customer = new Customer();
        $customer->assignOldValues(['' => 'sentinel', 'name' => 'user1']);

        $customer->markPropertyChanged('');

        $this->assertSame(['' => 'sentinel', 'name' => 'user1'], $customer->oldValues());
    }

I see no reason to limit markPropertyChanged('') method to an empty string.

active-record/src/AbstractActiveRecord.php

Lines 390 to 395 in f18e010

	public function markPropertyChanged(string $name): void
	{
	if ($this->oldValues !== null && $name !== '') {
	unset($this->oldValues[$name]);
	}
	}

[samdark]

That's weird. I don't think empty string should be passed there at all.

[Tigrov]

That's weird. I don't think empty string should be passed there at all.

Yes, it shouldn`t, as for example '!'. But also there is no reason to limit it. And if limit this here, then limit this in every other methods, what will reduce performance.

By the way, when we add a map, it will be possible to substitute 'column_name' => ''

https://onlinephp.io/c/32570