Preserve modification time of rotated log files in FileRotator.#84
Open
terabytesoftw wants to merge 6 commits into
Open
Preserve modification time of rotated log files in FileRotator.#84terabytesoftw wants to merge 6 commits into
FileRotator.#84terabytesoftw wants to merge 6 commits into
Conversation
terabytesoftw
commented
Jun 9, 2026
Member
| Q | A |
|---|---|
| Is bugfix? | ✔️ |
| New feature? | ❌ |
| Breaks BC? | ❌ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #84 +/- ##
============================================
+ Coverage 86.73% 87.12% +0.39%
- Complexity 36 38 +2
============================================
Files 2 2
Lines 98 101 +3
============================================
+ Hits 85 88 +3
Misses 13 13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR fixes log rotation behavior so that rotated log files keep the original file’s modification timestamp, including when rotation uses gzip compression.
Changes:
- Update
FileRotator::rotate()to capture the source file mtime and apply it to the rotated file viatouch(). - Add a PHPUnit test ensuring rotated files preserve modification time for both compressed and uncompressed rotation.
- Document the bugfix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/FileRotator.php |
Captures source filemtime() and applies it to the rotated (and possibly compressed) destination file. |
tests/FileRotatorTest.php |
Adds regression test verifying mtime preservation for both compression modes. |
CHANGELOG.md |
Adds an entry describing the bugfix under the next release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samdark
reviewed
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.