Upgrade for symfony and php#8
Merged
Merged
Conversation
added 18 commits
August 27, 2025 14:48
…dern style - Added type hints and strict return types across all Order classes - Replaced constants by public const for clarity and PSR-12 compliance - Unified XML (toXML/createFromXML) signatures and logic - Simplified inheritance for Address, Customer, Receiver, Sender, etc. - Enforced validation exceptions (length, values) consistently - Improved code readability and maintainability
- Ajout de strict_types=1 sur toutes les classes - Typage strict des propriétés, méthodes et retours - Harmonisation des méthodes createFromXML avec retour typé - Correction des constantes et renommages cohérents - Simplification de Address et factorisation dans PugoAddress/ParcelsDepotAddress - Validation des valeurs (length, value, weight) via exceptions dédiées - Refactor des classes Order, Box, Label et ProductConfiguration - Nettoyage du code obsolète, docblocks et cohérence générale Dossier Bpost finalisé et prêt à l’usage
- Added full type declarations and return types across Common namespace - Improved BasicAttribute and ValidatedValue with stricter validation methods - Cleaned up redundant phpdoc in favor of native type hints - Implemented specific BasicAttribute subclasses: - EmailAddressCharacteristic - Language - PhoneNumber - Implemented ValidatedValue subclass: - LabelFormat - Simplified ComplexAttribute as empty abstract base class - Updated IAttribute interface with consistent naming (toXml/createFromXml) - Refactored XmlHelper with stricter handling and validation
- Migration vers PHP 8.4 avec typage strict et propriétés nullables - Ajout de constantes explicites pour les jours (Day) - Amélioration de la validation des jours et gestion des exceptions - Ajout de types pour les coordonnées et collections (Poi, Service) - Simplification des méthodes de parsing XML avec cast explicite - Classes finales pour éviter l’héritage non prévu (Service)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.