Render hosted production environment from image lock#137
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f685b79798
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ```bash | ||
| sudo .venv/bin/python scripts/render_hosted_managed_production_env.py \ | ||
| --image-lock hosted-managed-image-lock.json \ | ||
| --output /etc/0al/hosted-managed-production.env \ |
There was a problem hiding this comment.
Load the rendered env file before deployment
When operators follow this new renderer path, the file is written to /etc/0al/hosted-managed-production.env, but the later Start and probe commands still invoke docker compose and preflight from the process environment, and I found no --env-file or source step for this output. Docker Compose documents non-default environment files as being selected with --env-file, so following the runbook as written leaves the required PLATFORM_MANAGED_OPERATION_* variables unset unless the operator manually infers an extra load step.
Useful? React with 👍 / 👎.
Summary
Motivation
Goals
Changes
Validation
Commands run:
Results:
Risks / Notes
Checklist