Skip to content

Fix initialization report observability#391

Merged
SoundBlaster merged 2 commits into
mainfrom
codex/fix-initialization-observability-triage
Jul 11, 2026
Merged

Fix initialization report observability#391
SoundBlaster merged 2 commits into
mainfrom
codex/fix-initialization-observability-triage

Conversation

@SoundBlaster

@SoundBlaster SoundBlaster commented Jul 11, 2026

Copy link
Copy Markdown
Member

Summary

  • Accept Platform-owned workspace initialization execution reports without requiring generic read-only artifact fields.
  • Preserve fail-closed checks for canonical metadata, Git/Ontology authority aliases, and unknown may_* authority expansion.
  • Prevent a valid scoped initialization report from appearing as a failed managed operation.
  • Keep dry-run initialization evidence visible without treating it as completion.

Motivation

A successful hosted-operation-canary initialization report was rejected as invalid_artifact_contract, so Product Workspace showed a false workspace_initialization_execute failure even though the scoped hosted promotion dry-run succeeded.

Goals

  • Treat Platform initialization execution as its own producer contract.
  • Keep readiness and authority checks strict.

Out of scope: retrying or changing the successful promotion dry-run, deployment configuration, and production canary execution.

Changes

  • Add initialization-report-specific artifact validation.
  • Project ok and dry_run into managed operation observability.
  • Add regressions for successful reports, dry-run reports, and unsafe authority values.

Validation

  • Tests added/updated for changed behavior
  • Local checks passed

Commands run:

.venv/bin/python -m pytest tests/test_idea_to_spec_workspace.py -q
.venv/bin/python -m pytest tests/test_specspace_api_v1.py -q
make test
make lint

Results:

  • 112 passed, 17 subtests passed
  • 322 passed, 18 subtests passed
  • 977 full backend tests passed
  • Scoped API and browser verification: workspace_initialization_execute=completed, managed Failed: 0

Risks / Notes

  • Backward compatibility impact: Platform initialization reports remain lifecycle evidence; readiness is evaluated separately from artifact presence.
  • Migration/config changes required: none.
  • Known limitations: the production hosted canary remains a separate operational task.

Checklist

  • PR title clearly describes the change
  • Scope is focused and minimal
  • Documentation updated (or N/A)
  • API/artifact/UI-state changes distinguish presence from readiness/status
  • Temporary or intermediate paths are scoped to the current run/task where relevant
  • No secrets or sensitive data added

Copilot AI review requested due to automatic review settings July 11, 2026 09:16

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 08d4e962a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread viewer/idea_to_spec_workspace.py
Comment thread viewer/idea_to_spec_workspace.py Outdated
Comment thread viewer/idea_to_spec_workspace.py
@SoundBlaster SoundBlaster merged commit c2323fa into main Jul 11, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants