Add RFC review metadata validation#9
Merged
Conversation
81c3fa7 to
996d67e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The RFC review dashboard is becoming a planning surface, but its source data has no versioned schema or enforceable metadata invariants. A malformed profile, stale RFC anchor, dependency cycle, or unsupported maturity claim can currently reach the generated dashboard.
Goals
Changes
review-data.json, including an explicit transition mode and an all-or-none planning metadata bundle.review-data-check, Python unit tests, and negative fixtures to the existing review build gate.Validation
make review-check PYTHON=/tmp/agent-surface-maintenance-uv/bin/python/tmp/agent-surface-maintenance-uv/bin/python -m json.tool review/review-data.schema.json/tmp/agent-surface-maintenance-uv/bin/python -m json.tool review/review-data.jsonnode --check review/check_review.mjsgit diff --checkBoundaries and Non-Goals
specifiedand non-RFC evidence fail closed until authoritative evidence resolvers are added; arbitrary artifact paths cannot promote a card.blocksand readiness are derived state and are intentionally rejected if persisted.Notes
codex/action-execution-model). The next PR migrates all 60 cards onto this contract.