🧪 test: improve testing coverage for base64Url function#4
Conversation
- Add robust unit tests for base64Url in tests/serve.test.js - Wrap server.listen in require.main === module to prevent port collisions during testing - Export base64Url conditionally for testing Co-authored-by: megawron <52606827+megawron@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Deploying 0cms with
|
| Latest commit: |
44e3025
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9c8543c3.0cms.pages.dev |
| Branch Preview URL: | https://improve-base64url-testing-10.0cms.pages.dev |
- Updated `build.mjs` to use recursive `cp` instead of iterating and checking with `readdir` directly, which fixes `EISDIR` errors - Marked generated WASM JS and binary files as external in the Bun builder configuration to prevent CI resolution errors when the artifacts aren't built - Verified that `serve.test.js` remains intact and `base64Url` runs accurately. Co-authored-by: megawron <52606827+megawron@users.noreply.github.com>
1 participant
🎯 What: This PR addresses the missing edge case tests for the
base64Urlfunction inserve.js. Becauseserve.jspreviously started an HTTP server indiscriminately upon import, test files importing it caused side-effects. This was fixed to enable clean testing.📊 Coverage: The following scenarios are now tested using the Bun test framework:
+in Base64 (converted to-)/in Base64 (converted to_)=in Base64 (stripped out)✨ Result: The
base64Urlfunction is now fully covered, preventing potential regressions, andserve.jscan be safely imported without starting the HTTP server logic.PR created automatically by Jules for task 10114646235311564427 started by @megawron