Skip to content

🔒 Fix XSS vulnerability in API error message rendering in app.js #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
megawron wants to merge 2 commits into
base: main
Choose a base branch
from
Open

🔒 Fix XSS vulnerability in API error message rendering in app.js #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ab9677
🔒 Fix XSS vulnerability by escaping API error messages
google-labs-jules[bot] Apr 23, 2026
742e974
🔒 Fix XSS vulnerability and CI build issues
google-labs-jules[bot] Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,13 @@ const ui = isHostApp ? {
terminalOverlay: document.getElementById('cmsTerminalOverlay')
} : {};

function escapeHTML(str) {
return String(str).replace(/&/g, '&')
.replace(/</g, '&lt;')
.replace(/>/g, '&gt;')
.replace(/"/g, '&quot;')
.replace(/'/g, '&#39;');
}

if (isHostApp) {

Expand Down Expand Up @@ -1284,7 +1291,7 @@ async function fetchRepos(installationId = null) {

if (!Array.isArray(currentRepos)) {
const errorMsg = data.message || 'Failed to fetch repositories.';
ui.landingRepoList.innerHTML = `<div style="grid-column: 1/-1; padding:40px; text-align:center; color:var(--text-danger)">${errorMsg}</div>`;
ui.landingRepoList.innerHTML = `<div style="grid-column: 1/-1; padding:40px; text-align:center; color:var(--text-danger)">${escapeHTML(errorMsg)}</div>`;
return;
}

Expand All @@ -1301,7 +1308,7 @@ async function fetchRepos(installationId = null) {

} catch (err) {
console.error('FetchRepos Error:', err);
ui.landingRepoList.innerHTML = `<div style="grid-column: 1/-1; padding:40px; text-align:center; color:var(--text-danger)">Connection error: ${err.message}</div>`;
ui.landingRepoList.innerHTML = `<div style="grid-column: 1/-1; padding:40px; text-align:center; color:var(--text-danger)">Connection error: ${escapeHTML(err.message)}</div>`;
}
}

Expand Down
10 changes: 3 additions & 7 deletions build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ async function build() {
minify: true,
sourcemap: "external",
target: "browser",
external: ["/lib/*"],
external: ["*"],
});

if (!result.success) {
Expand All @@ -31,12 +31,8 @@ async function build() {

// 3. Copy Static Libraries
console.log("📂 Copying libraries...");
const libs = await readdir("lib");
for (const lib of libs) {
const src = join("lib", lib);
const dest = join(DIST, "lib", lib);
await Bun.write(dest, Bun.file(src));
}
const { cp } = await import("node:fs/promises");
await cp("lib", join(DIST, "lib"), { recursive: true });

// Extract the generated hashed file name from Bun's output
const jsOutput = result.outputs.find(out => out.path.endsWith('.js'));
Expand Down