Fix null Pointer Exeption in AetherChunkData#12
Merged
0vergrown merged 1 commit into0vergrown:masterfrom Nov 16, 2025
Merged
Conversation
Makes sure that the world is set in AetherChunkData when it is loaded from disk.
Owner
|
Okay, I actually merged this and then updated the Modrinth maven and then updated Thaumaturge with the new version (1.1.8) so this PR should be working on there too 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if AetherChunkData is loaded from disk, the final world variable is set to null.
If the world is loaded from disk and a particular chunk was saved and becomes corrupted this can cause a Null Pointer Exception:
java.lang.NullPointerException: Cannot invoke "net.minecraft.world.World.isClient()" because "world" is null at knot//dev.overgrown.aspectslib.aether.AetherManager.isDeadZone(AetherManager.java:79) at knot//dev.overgrown.aspectslib.aether.AetherChunkData.canHarvest(AetherChunkData.java:98) at knot//dev.overgrown.aspectslib.aether.AetherChunkData.harvestAether(AetherChunkData.java:107) at knot//dev.overgrown.aspectslib.corruption.CorruptionManager.processAetherConsumption(CorruptionManager.java:306) at knot//dev.overgrown.aspectslib.corruption.CorruptionManager.processRegionCorruption(CorruptionManager.java:138) at knot//dev.overgrown.aspectslib.corruption.CorruptionManager.processWorldCorruption(CorruptionManager.java:86) at knot//dev.overgrown.aspectslib.corruption.CorruptionManager.onServerTick(CorruptionManager.java:52)This PR fixes the problem by having AetherWorldState set the world variable of all its loaded AetherChunkData objects on the first call to get any AetherChunkData.