Modify Finnish resource for recent activity message#534
Conversation
Updated the 'No recent activity' message in Finnish resources.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d8073908a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| </data> | ||
| <data name="FeedsPageNoRecentActivityBody.Text" xml:space="preserve"> | ||
| <value>No recent activity.</value> | ||
| <value>No recent activity.AAAA</value> |
There was a problem hiding this comment.
The Finnish resource value for FeedsPageNoRecentActivityBody.Text now includes an extra AAAA suffix, so users in the fi-FI locale will see No recent activity.AAAA in the feed empty-state UI instead of a clean message. This is a user-visible regression introduced by this commit and should be reverted to the intended text.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
Updates a localized resource string for the app’s “recent activity” empty-state message in the FluentHub WinUI resource bundle.
Changes:
- Modifies
FeedsPageNoRecentActivityBody.Textin the Finnish (fi-FI)Resources.resw. - Adjusts the file ending line formatting (no functional impact).
| </data> | ||
| <data name="FeedsPageNoRecentActivityBody.Text" xml:space="preserve"> | ||
| <value>No recent activity.</value> | ||
| <value>No recent activity.AAAA</value> |
There was a problem hiding this comment.
The localized string value has an obvious typo (AAAA) appended and is missing the expected spacing/punctuation, which would surface directly in the UI if shipped.
| <value>No recent activity.AAAA</value> | |
| <value>No recent activity.</value> |
| <data name="FeedsPageNoRecentActivityBody.Text" xml:space="preserve"> | ||
| <value>No recent activity.</value> | ||
| <value>No recent activity.AAAA</value> |
There was a problem hiding this comment.
This PR directly modifies a non-en-US resource file (fi-FI). Per the repo localization workflow, changes should be made in src/FluentHub.App/Strings/en-US/*.resw and propagated via Crowdin sync; please revert manual edits in fi-FI/Resources.resw unless this commit is an automated Crowdin update.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
No description provided.