compare evaluation winterfell plonky3#533
Open
Soulthym wants to merge 89 commits into0xMiden:nextfrom
Open
Conversation
TODO: can't evaluate without constraints on winterfell TODO: aux width mismatch in build_aux_trace
…-up needed TODO: can't evaluate without constraints on winterfell
…up needed TODO: can't evaluate without constraints on winterfell
…p needed TODO: can't evaluate without constraints on winterfell
…p needed TODO: can't evaluate without constraints on winterfell
Collaborator
Author
|
This PR should be ready for review, the only remaining work should be to rebase on next once #461 is merged. I've added tests comparing evaluations for all current golden tests (air-script/src/tests) between Winterfell and Plonky3. NOTE: some simple bus tests do not have any constraints on the main trace, which leads to Winterfell not being able to initialize the prover. I have marked those tests as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Solves #532.
This implements a test harness comparing evaluations on plonky3 and winterfell generated constraints. It compares evaluations on random traces and tailored made ones to account for valid/invalid traces scenarios.
Left as a draft until the task list is marked as completed.
Task list:
Checklist before requesting a review
Repo forked and branch created from
nextaccording to naming convention.This branch is based on the current state of Add plonky3 backend #461
Commit messages and codestyle follow conventions.
Commits are signed.
Relevant issues are linked in the PR description.
Tests added for new functionality.
Documentation/comments updated according to changes.
Updated
CHANGELOG.md