fix: move proto code generation output to OUT_DIR, out of tree#1703
Open
fix: move proto code generation output to OUT_DIR, out of tree#1703
OUT_DIR, out of tree#1703Conversation
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I think is better and minimizes the review diffs when proto changes are involved.
It also makes sense to me to drop the generated/mod.rs codegen but as you say that probably makes more sense as a separate PR. This file can be created manually.
This looks correct; but PR is still in draft and description looks semi-done so I'm not approving yet.
34b453c to
d5326f2
Compare
Contributor
Author
|
Added CI and Makefile changes, which were the last missing pieces. |
Mirko-von-Leipzig
approved these changes
Feb 25, 2026
Collaborator
Mirko-von-Leipzig
left a comment
There was a problem hiding this comment.
I would hold off on merging this until @bobbinth agrees with this in principle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Committing generated protobuf code is discouraged and creates review churn. Moving artifacts to
OUT_DIRremoves ~10k LOC from the repo and avoids frequent diffs when protobuf definitions change.rust-analyzerresolvesinclude!paths, so location is no longer a blocker when it comes to symbol resolution / editor support.Implementation
We keep the existing integration wiring by continuing to use i.e.
generated/mod.rsandinclude!(concat!(env!("OUT_DIR"), "/generated/…")). This minimizes import-path changes across the codebase and keeps the diff concise.Side effects
docs.rs-specificBUILD_PROTO=1special casing.Risks