Add fuzz testing and diverse XLSX test corpus#52
Merged
Conversation
- 4 cargo-fuzz targets covering all reader entry points (read_xlsx, read_single_sheet, read_sheet_names, read_document_properties) - 23 generated fixture files: valid corpus (16 files testing different features, data types, Unicode, rich text, sparse rows, multiple sheets, etc.) and malformed corpus (7 files: truncated ZIP, empty ZIP, missing workbook, malformed XML, bad string index, etc.) - test_corpus.py: 30 Python tests exercising the corpus (valid parse, malformed error handling, write-read roundtrip) - generate_corpus.py: reproducible fixture generation script - CI workflow (fuzz.yml): weekly scheduled + on-demand + PR trigger for reader changes, with corpus caching and crash artifact upload - docs/edge-cases.md: documented known edge cases and security limits - Made reader/writer/types modules public for fuzz target access Closes #19
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
read_xlsx,read_single_sheet,read_sheet_names,read_document_properties)fuzz.yml): weekly scheduled + on-demand + PR trigger for reader changes, corpus caching, crash artifact uploaddocs/edge-cases.md): security limits, known behaviors for malformed inputTest plan
cargo clippy --no-default-features -- -D warningscleancargo fmt --checkcleancargo +nightly fuzz buildcompiles all 4 targetscargo +nightly fuzz run fuzz_read_xlsx -- -max_total_time=10runs without crashesCloses #19