templates: replace dead witnessprotocol with witness.enable hint#2204
Open
apetro2 wants to merge 2 commits into0xPolygon:developfrom
Open
templates: replace dead witnessprotocol with witness.enable hint#2204apetro2 wants to merge 2 commits into0xPolygon:developfrom
apetro2 wants to merge 2 commits into0xPolygon:developfrom
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
kamuikatsurgi
previously approved these changes
Apr 30, 2026
|
pratikspatil024
requested changes
May 4, 2026
| path: cover.out | ||
|
|
||
| codecov: | ||
| if: (github.event.action != 'closed' || github.event.pull_request.merged == true) |
Member
There was a problem hiding this comment.
these changes are irrelevant to the PR, please merge/rebase the latest develop
| # snapshot = true | ||
| # "bor.logs" = false | ||
| # ethstats = "" | ||
| # witnessprotocol = false |
Member
There was a problem hiding this comment.
better to remove it from here and add it in it's original place somewhere below in the config. bor dumpconfig command will help
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• # Description
This PR fixes a configuration template correctness issue where
witnessprotocolwas still shown as a top-level key in Bor config templates.That key is no longer consumed by the current CLI config parser path for template TOML usage; witness protocol enablement is now controlled via
[witness].enable.What was done:
# witnessprotocol = falsewith:# [witness]# enable = falseUpdated files:
packaging/templates/mainnet-v1/without-sentry/bor/config.tomlpackaging/templates/mainnet-v1/without-sentry/bor/pbss_config.tomlpackaging/templates/mainnet-v1/sentry/sentry/bor/config.tomlpackaging/templates/mainnet-v1/sentry/sentry/bor/pbss_config.tomlpackaging/templates/mainnet-v1/sentry/validator/bor/config.tomlpackaging/templates/mainnet-v1/sentry/validator/bor/pbss_config.tomlpackaging/templates/testnet-amoy/without-sentry/bor/config.tomlpackaging/templates/testnet-amoy/sentry/sentry/bor/config.tomlpackaging/templates/testnet-amoy/sentry/validator/bor/config.tomlbuilder/files/config.tomlChanges
Nodes audience
This change affects node operators who use these packaging/builder templates to generate or update
config.toml.Existing nodes that do not regenerate config from these templates are not impacted.
No runtime flag behavior was changed; this PR only corrects template guidance to the valid
[witness].enablepath.Checklist
Cross repository changes
Testing
Manual tests
internal/cli/server/config.goconfirms witness protocol derives fromc.Witness.Enable.witnessprotocoland now contain commented[witness]+enable.Note: attempted Go test execution, but local environment could not download required Go toolchain (
go1.26.2) due network timeout, so automated test execution could not be completed in this environment.Additional comments
There are additional non-target files in the repository that still reference
witnessprotocol(e.g. some pbss/archive templates and docs examples).They were intentionally left out to keep this PR scoped to the requested files.