Skip to content

Use proxy factory for NFTs#3

Open
Agusx1211 wants to merge 14 commits intomasterfrom
factory
Open

Use proxy factory for NFTs#3
Agusx1211 wants to merge 14 commits intomasterfrom
factory

Conversation

@Agusx1211
Copy link
Copy Markdown
Member

@Agusx1211 Agusx1211 commented Oct 15, 2021

  • Use proxy factory instead of deploying full contracts
  • Add contract tests
  • Add coverage tasks (100%)
  • Cheap NFT creation (92k gas per contract)

@Agusx1211 Agusx1211 requested a review from pkieltyka October 15, 2021 16:20
Copy link
Copy Markdown
Member

@pkieltyka pkieltyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks amazing, and cool to see the achievement of 92k gas deployments, that is a game changing for niftyup. Left one small comment

Comment thread src/contracts/NiftyupFactory.sol Outdated
@Agusx1211
Copy link
Copy Markdown
Member Author

Depends on 0xsequence/erc-1155#79

@Agusx1211 Agusx1211 requested a review from pkieltyka October 22, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants