Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new DeferredBus abstraction that enables deferred execution of commands, queries, and events in FastAPI applications. The implementation leverages FastAPI's BackgroundTasks to execute operations asynchronously without blocking the response.
- Adds a new
DeferredBusprotocol for deferred execution - Implements FastAPI-specific deferred bus variants for commands, events, and queries
- Provides dependency injection integration through annotated types
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cq/_core/defer.py | Defines the core DeferredBus protocol with abstract defer method |
| cq/init.py | Exports the new DeferredBus class in the public API |
| cq/ext/fastapi.py | Implements FastAPI-specific deferred buses using BackgroundTasks |
| cq/ext/fastapi.pyi | Provides type aliases for the three deferred bus variants |
| tests/ext/test_fastapi.py | Adds comprehensive test coverage for the FastAPI deferred bus functionality |
| pyproject.toml | Adds FastAPI and httpx as test dependencies |
| documentation/fastapi-example.md | Updates documentation with usage example for the new deferred bus |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.