fix: 🩹 pass owner to __get__ - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the descriptor access pattern by properly passing the owner argument to the __get__ method. The change ensures that when accessing the handle method from a handler type, both the instance and owner arguments are correctly provided to the descriptor protocol.
- Updated the
__get__method call to include the owner parameter - Renamed the variable from
fake_handle_methodtofake_methodfor clarity
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.