Skip to content

fix: 🩹 pass owner to __get__ - #49

Merged
remimd merged 1 commit into
devfrom
descriptors
Oct 12, 2025
Merged

fix: 🩹 pass owner to __get__#49
remimd merged 1 commit into
devfrom
descriptors

Conversation

@remimd

@remimd remimd commented Oct 12, 2025

Copy link
Copy Markdown
Member

No description provided.

@remimd
remimd requested a review from Copilot October 12, 2025 08:34
@remimd remimd self-assigned this Oct 12, 2025

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug in the descriptor access pattern by properly passing the owner argument to the __get__ method. The change ensures that when accessing the handle method from a handler type, both the instance and owner arguments are correctly provided to the descriptor protocol.

  • Updated the __get__ method call to include the owner parameter
  • Renamed the variable from fake_handle_method to fake_method for clarity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cq/_core/handler.py
@remimd
remimd merged commit 4b41a52 into dev Oct 12, 2025
6 checks passed
@remimd
remimd deleted the descriptors branch October 12, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants