Enhance data descriptor handling by adding length check#233
Open
johan-tribus wants to merge 1 commit into101arrowz:masterfrom
Open
Enhance data descriptor handling by adding length check#233johan-tribus wants to merge 1 commit into101arrowz:masterfrom
johan-tribus wants to merge 1 commit into101arrowz:masterfrom
Conversation
Previously, a chunk could coincidentally contain a data descriptor signature in an unexpected position, causing the decoder to halt and throw an unexpected EOF error when reading a .zip stream archive. This update introduces a length check on the compressed size, allowing the decoder to continue processing if there are still bytes left to be deflated.
Owner
|
The reason I didn't do this to begin with is that ZIPs that are compressed in a streaming way have the length in the local header set to 0 AFAIK. Does this still work with such files? If you aren't able to test this I will do so in a few days. Thanks for your patience on this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, a chunk could coincidentally contain a data descriptor signature in an unexpected position, causing the decoder to halt and throw an unexpected EOF error when reading a .zip stream archive. This update introduces a length check on the compressed size, allowing the decoder to continue processing if there are still bytes left to be deflated.