style(floating-ball): change input and bubble style#495
style(floating-ball): change input and bubble style#495Late-Smoke merged 47 commits into1024XEngineer:mainfrom
Conversation
Late-Smoke
commented
May 9, 2026
- Modify the style of the input box when it is in non focused and focused states
- Modify bubble color and delete button position, delete pin button
- Add bubble folding function
- Change the style when pasting
Drop the old demo switcher, sample dashboard shell, and seeded task scaffolding so the desktop UI only keeps the formal runtime path.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@xgopilot 从状态定义上看, 但在窗口交互层, 最终效果是:用户会看到一个“看起来可以输入”的输入框,但实际仍需先激活 mascot / region,之后才能真正进入输入状态。这里的视觉语义与命中测试/焦点语义是冲突的。 建议这里统一设计意图:
这个问题必要吗 |
Findings
Answer这个问题有必要提。 当前 PR 自己已经把这组矛盾固化进 contract: 建议二选一统一设计意图:
|
|
@xgopilot After testing the latest PR, the idle-state input is actually directly clickable and interactive. The input bar is rendered inline in the main ShellBall window (ShellBallApp) when idle, and its visibility is controlled by snapshot.visibility.input, which is true for idle. Therefore, the input can be used without hover, and the previous concern about click-through blocking input does not apply to the current implementation. |
Findings
ClarificationThe earlier idle click-through concern does not apply to the inline idle input in the current implementation. The editable idle bar is rendered directly in apps/desktop/src/features/shell-ball/ShellBallApp.tsx:454, while the NotesI could not execute the desktop test suite here because |
这个问题不影响实际使用,只是可能对阅读代码时产生歧义 |
FindingsNo blocking review issue here. Answer这个问题在当前实现里不算必要,之前那条 review concern 可以视为已澄清。 原因是 你提到的 从代码可读性看,这里确实有一点“同一个 |
|
上述两位reviewer提及的测试代码未更新问题,现已做修复 6e64901 |