feat(dashboard): unify escape fallback hierarchy#496
Merged
liche719 merged 5 commits intoMay 11, 2026
Conversation
Route-level Escape now unwinds local dashboard overlays before returning module pages to home, and only allows the desktop window to close from the home route. This keeps fallback behavior consistent across task, mirror, safety, and home surfaces.
Restore the notes page Escape hierarchy so source-note studio and note detail panels unwind before the route falls back to dashboard home. Keep the contract test aligned with the restored notes-specific escape handlers.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
gdemonc
requested review from
Late-Smoke and
liche719
and removed request for
liche719
Collaborator
|
/review |
Closed
![fennoai[bot]](https://avatars.githubusercontent.com/in/1924301?s=60&v=4){kind=small}
Open
Let the dashboard voice field use the shared route-level Escape coordinator so voice dismiss follows the same fallback ladder as other dashboard overlays. Keep the latest notes-page external-url import aligned with the rebased branch state.
Collaborator
Author
|
@xgopilot 现在还有问题吗？ |
Contributor
Review这轮基于 本次结论是静态审查结果：
校验限制：本地尝试执行 |
Late-Smoke
approved these changes
May 11, 2026
liche719
approved these changes
May 11, 2026
Blackcloudss
added a commit
that referenced
this pull request
May 11, 2026
…t task flow (#506) * style(local-service): clarify backend go comments * ci(local-service): block chinese go comments * refactor(orchestrator): stage task entry flows * refactor(rpc): align entrypoint decoding with protocol * test(rpc): guard protocol method registry * fix(orchestrator): reuse free-text flow for notepad tasks * docs(protocol): refresh notepad task conversion example * fix(orchestrator): make notepad conversion rollback-safe Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * chore(local-service): sync taskcontext merge changes Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): preserve task-start tracing and explicit inputs Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * chore(desktop): sync notepad convert test stub contract Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): keep related resources out of task files * fix(notepad): restore explicit resource snapshot inputs Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): restore convert task confirmation flow Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * docs(protocol): fix notepad convert_to_task response example Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): tighten convert-to-task rollback boundaries Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): persist legacy note conversion provenance Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): keep internal provenance out of RPC items Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): avoid guessing legacy conversion provenance Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * docs(notepad): clarify legacy convert-to-task note text semantics Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): preserve explicit file attachments and cleared note provenance Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): dedupe explicit snapshot attachments Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): align convert task with free-text flow Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): rollback failed direct conversions Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): constrain convert snapshot resource paths Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): keep published convert tasks after start failure Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): keep directory resources out of snapshot files Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): keep published failure note linkage consistent Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notes): gate auto-open on supported delivery targets Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(notepad): tighten convert task resource promotion Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * feat(dashboard): unify escape fallback hierarchy (#496) * feat(dashboard): unify escape fallback hierarchy Route-level Escape now unwinds local dashboard overlays before returning module pages to home, and only allows the desktop window to close from the home route. This keeps fallback behavior consistent across task, mirror, safety, and home surfaces. * fix(dashboard): restore notes escape fallback Restore the notes page Escape hierarchy so source-note studio and note detail panels unwind before the route falls back to dashboard home. Keep the contract test aligned with the restored notes-specific escape handlers. * fix(dashboard): route voice escape through fallback hierarchy Let the dashboard voice field use the shared route-level Escape coordinator so voice dismiss follows the same fallback ladder as other dashboard overlays. Keep the latest notes-page external-url import aligned with the rebased branch state. * fix(desktop): stop shell-ball from attaching foreground page context (#523) * fix(shell-ball): clear hover input immediately after submit * fix(dashboard): add task delivery page and sync task status * fix(shell-ball): support top and bottom edge docking * fix(shell-ball): add edge snap animation * fix(dashboard): include browser context in voice submit * fix(shell-ball): attach browser page context on submit * fix(shell-ball): surface detected browser urls in bubbles * fix(dashboard): limit voice context reuse to browser pages * fix(desktop): restore corrupted contract test copy Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: liche719 <203191226+liche719@users.noreply.github.com> * fix(shell-ball): remove auto-detected page bubble display (#461) * fix(desktop): stop shell-ball from attaching page context --------- Co-authored-by: xgopilot <noreply@goplus.org> Co-authored-by: liche719 <203191226+liche719@users.noreply.github.com> --------- Co-authored-by: xgopilot <noreply@goplus.org> Co-authored-by: gdemonc <146809967+gdemonc@users.noreply.github.com> Co-authored-by: liche <3372134858@qq.com> Co-authored-by: liche719 <203191226+liche719@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solve #489
Summary
Testing