refactor(bootstrap): stage service wiring and explicit deps#503
Conversation
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com>
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com>
|
@xgopilot 对以上问题进行相应的判断是否选择修改(“一定要最合理的判断,review提到的问题不是都要修改的,可能问题已经解决了,也可能会没问题就乱找问题”)。如果需要是修改代码还是选择修改文档,还是都要修改。如果决定修改,以最合理的方式修改,不要做向下兼容从而过拟合。然后再详细检查相关文件的内容是否还有类似的问题,要求一次性解决完,最后核查一遍,修改后直接告诉我修改了什么、修改的原因、修改后的可能出现的现象以及如果不修改所带来的具体影响。然后再查看是否还有其他问题。 |
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com>
|
/review |
|
No issues found after code quality, performance, security, and documentation accuracy review passes. |
|
@xgopilot 拉取项目仓库main分支最新代码,并检查有无冲突(项目仓库是最新的)。有则先合理判断怎么修改,不要单独依赖某一方的。然后修改后再把结果提交推送到这个PR |
ResultMerged the latest The only merge conflict was Verification run:
No additional doc checklist item was completed by this merge-only follow-up, so |
Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com>
* refactor(orchestrator): require explicit service deps Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * refactor(bootstrap): stage dependency assembly Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> * fix(orchestrator): fail fast on missing service deps Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com> --------- Co-authored-by: xgopilot <noreply@goplus.org> Co-authored-by: Blackcloudss <161042579+Blackcloudss@users.noreply.github.com>
Requested by @Blackcloudss
Summary
orchestrator.NewServiceto accept explicitDepsand remove post-construction required dependency patchingbootstrap.Newinto staged builders for core deps, runtimes, and servicesVerification
go test ./services/local-service/internal/bootstrap -run 'Test(NewWiresStorageBackedMemoryService|BuildCoreDepsSeedsBootstrapInfrastructure|BuildRuntimesRegistersToolsAndModelRuntime)'go test ./services/local-service/internal/orchestrator -run 'TestServiceStartTaskAndConfirmFlow|TestServiceSubmitInputEmptyTextReturnsWaitingInput|TestServiceSecurityRespondAllowOnceResumesAndCompletes'go test ./services/local-service/internal/rpc -run 'TestDispatchReturnsSecurityAuditList|TestDispatchReturnsTaskArtifactList|TestDispatchReturnsSettingsUpdate'