Skip to content

fix: support gemini-embedding-001 provider config#324

Merged
TheShigure7 merged 2 commits into1024XEngineer:mainfrom
TheShigure7:pr/gemini-embedding-fix
May 10, 2026
Merged

fix: support gemini-embedding-001 provider config#324
TheShigure7 merged 2 commits into1024XEngineer:mainfrom
TheShigure7:pr/gemini-embedding-fix

Conversation

@TheShigure7
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

@fennoai fennoai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one regression in the changed Gemini provider logic.

Comment thread pkg/embedding/gemini.go Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 9, 2026

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/embedding/gemini.go 85.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@TheShigure7 TheShigure7 merged commit ad12ed0 into 1024XEngineer:main May 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants