架构设计#162
Conversation
There was a problem hiding this comment.
Found 3 noteworthy issues in this PR:
- New
.gointerface docs underdocs/bytemind-architecture/*/interface.gocurrently do not compile. - Policy decision-priority documentation is internally inconsistent.
- Storage/audit ownership is inconsistent between overview and module docs.
Please address these to keep the architecture docs executable/consistent.
| - `SensitiveFileGuard`:敏感文件读取防护。 | ||
|
|
||
| ## 4. 决策优先级 | ||
| `explicit deny > explicit allow > risk rule > mode default > fallback ask` |
There was a problem hiding this comment.
This priority order conflicts with the top-level architecture doc (docs/bytemind-architecture/README.md:204). The two versions disagree on both hard_deny existence and the ordering of risk_rule vs explicit_allow, which changes enforcement semantics. Please define one canonical order and reuse it everywhere.
Added additional transitions to the architecture diagram.
|
@xgopilot 我看了 docs/bytemind-architecture/README.md 这个: |
结论(针对你提的 4 个点)
额外提醒当前文档内有一处优先级冲突,建议先统一:
本次处理范围
|
520wheat
left a comment
There was a problem hiding this comment.
补充一次任务流程图、core层的职责、agent读取session快照的补充解释
|
|
||
| ### 10.1 单代理主闭环 | ||
| 1. 用户提交消息到 `agent`。 | ||
| 2. `agent` 读取 `session` 快照。 |
There was a problem hiding this comment.
agent在处理这次的新提交时,需要先拿到该会话的“完整状态”(历史消息,build/plan模式,计划进行状态,元数据……)。
agent用来继续上下文,而不是将每次请求作为新对话,即使程序重启,也能从持久化状态恢复,不丢上下文
|
|
||
| ### core | ||
| - 做:跨模块共享基础类型(SessionID/TaskID/Role/Decision/RiskLevel/TaskStatus)与通用错误契约。 | ||
| - 不做:业务流程、模块专属请求结构、具体实现。 |
There was a problem hiding this comment.
这一层主要记录一些统一的契约规范
任务状态码均为:pending/running/completed/failed/killed
权限决策值:allow/deny/ask
……
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Updated the architecture diagram and added user interactions.
No description provided.