Skip to content

chore: remove unused CURRENCY_TO_COUNTRY dict from RemitlyScraper#17

Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1772894779-remove-unused-currency-to-country
Open

chore: remove unused CURRENCY_TO_COUNTRY dict from RemitlyScraper#17
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin/1772894779-remove-unused-currency-to-country

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

chore: remove unused CURRENCY_TO_COUNTRY dict from RemitlyScraper

Summary

Removes the CURRENCY_TO_COUNTRY class attribute (formerly lines 29–39) from RemitlyScraper in scrapers/remitly.py. This dict mapped currency codes to ISO-3166 country codes but was never referenced by any method in the class — _get_estimate() passes currency codes directly to the Remitly API params, and _scrape_landing_page() builds URLs from currency codes directly. A repo-wide grep confirms zero references beyond the definition itself.

The dict was added speculatively during initial code generation and was dead on arrival. (Note: the analogous CURRENCY_TO_ISO2 dict in westernunion.py is actively used, confirming this was intended but never wired up.)

Review & Testing Checklist for Human

  • Verify no dynamic access to CURRENCY_TO_COUNTRY exists (e.g. via getattr(self, ...) or cls.__dict__ patterns) that a simple grep would miss
  • Confirm the scraper still works end-to-end by running a test quote through RemitlyScraper.get_quote() for at least one currency pair

Notes

Co-Authored-By: bot_apk <apk@cognition.ai>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants