This repository was archived by the owner on Nov 7, 2018. It is now read-only.
Open
Conversation
edited some sentences in API.md
I edited some word and sentences in CONTRIBUTING.md
Fixed word int the Install.md
jayvdb
reviewed
Nov 3, 2016
| Treat commit messages as an email message that describes what you changed and why. | ||
|
|
||
| The first line of the commit log must be treated as as an email | ||
| The first line of the commit log |
There was a problem hiding this comment.
I think the current text was better than your modification, here.
It could be simplified to:
The first line of the commit log is the email subject.
That removes line being repeated, and strictly speaking the email subject line must have the prefix Subject: , which is not needed in the commit log first line.
|
Please fix your commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I edited and fixed some miss words or sentences.