Skip to content

anujchoudhary-17 : Fixed - Error loading local files on Windows machines #28 issue #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anujchoudhary-17 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

anujchoudhary-17 : Fixed - Error loading local files on Windows machines #28 issue #44

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84d1a87
src\index.ts added a boolean function name validatingURLusingRegex to…
anujchoudhary-17 Jun 10, 2023
688c89a
Update index.ts
anujchoudhary-17 Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions packages/docusaurus-plugin-stored-data/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,14 @@ const httpsPromise = (
const getData = async (location: string): Promise<string> => {
try {
new URL(location); // will throw if invalid URL

const response = await httpsPromise(location);
return response.body;
if (validateUrl(location)){
const response = await httpsPromise(location);
return response.body;
}
else{
throw "Location URI is not in the proper format";
}

} catch (error) {
// If it's just an invalid URL, let it fall through to check if it's a file
if (
Expand Down Expand Up @@ -78,6 +83,15 @@ const getData = async (location: string): Promise<string> => {
throw new Error(`Could not determine if ${location} is a URL or file`);
};


const validateUrl = (locationString : string): Boolean => {
try {
const url = new URL(locationString);
return url.protocol === "http:" || url.protocol === "https:";
} catch {
return false;
}
}
const pluginStoredData = (
_: LoadContext,
{ data = {} }: Options,
Expand Down