Prevent DLL injection from third-party software (Astrill VPN)#7
Draft
Copilot wants to merge 2 commits intono-nightlyfrom
Draft
Prevent DLL injection from third-party software (Astrill VPN)#7Copilot wants to merge 2 commits intono-nightlyfrom
Copilot wants to merge 2 commits intono-nightlyfrom
Conversation
Remove LOAD_LIBRARY_SEARCH_USER_DIRS flag from SetDefaultDllDirectories to prevent third-party DLL injection. This fixes crashes caused by Astrill VPN's ASProxy64.dll being injected into RustDesk process. Fixes: rustdesk#7010 (reply in thread) Co-authored-by: 21pages <14891774+21pages@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in discussion comment 15739560
Prevent DLL injection from third-party software (Astrill VPN)
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Astrill VPN injects
ASProxy64.dllinto RustDesk's process space, causing access violations when it callsAuthenticateLicense. The current DLL search path allowed loading from user directories viaLOAD_LIBRARY_SEARCH_USER_DIRS.Changes
LOAD_LIBRARY_SEARCH_USER_DIRSfromSetDefaultDllDirectoriescallLOAD_LIBRARY_SEARCH_SYSTEM32)This hardens against DLL injection attacks from any third-party software, not just Astrill.
Affected: Windows non-debug builds only
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
chromium.googlesource.com/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https REDACTED REDACTED grep -l evc_amf /macos/macos_impl.rs /usr/bin/grep --global(dns block)/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https REDACTED REDACTED grep -l evc_amf ld.rs k/_temp/ghcca-node/node/bin/grep --global user.email rgo/bin/grep grep -l evc_amf(dns block)/usr/lib/git-core/git-remote-https /usr/lib/git-core/git-remote-https REDACTED REDACTED grep -l evc_amf s(dns block)https://api.github.com/repos/rustdesk/rustdesk/discussions/usr/bin/curl curl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.