Universal module definition (umd) support added #7
Open
imefisto wants to merge 1 commit into2is10:masterfrom
Open
Universal module definition (umd) support added #7imefisto wants to merge 1 commit into2is10:masterfrom
imefisto wants to merge 1 commit into2is10:masterfrom
Conversation
2is10
requested changes
Feb 14, 2017
Owner
2is10
left a comment
There was a problem hiding this comment.
Thanks! Could you do this without touching so many lines? With the factory function added, the IIFE is no longer needed. Seems like the file could start with this:
// github.com/2is10/selectionchange-polyfill
(function (root, factory) {
if (typeof define === "function" && define.amd) {
define([], factory);
} else if (typeof exports === "object") {
module.exports = factory();
} else {
root.selectionchange = factory();
}
}(this, function (undefined) {
var MAC = /^Mac/.test(navigator.platform);
......and nothing else would need to change except removing this from the bottom:
if (typeof module !== 'undefined') {
// CommonJS/Node compatibility.
module.exports = selectionchange;
}
Owner
|
Also, please stick with the indentation level this file is already using: 2 spaces. Thanks. P.S. Good news, Firefox 52 (scheduled for release March 7) has the selection events API. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ! I've used your code with requirejs, so I've added UMD support.
Thank you.