Refactor time-integrator storage resolution#47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors transient storage resolution so weak forms expose their own storage providers instead of time integrators inferring storage from implementation-specific material attributes.
Main Changes
WeakFormBase.get_storage()andget_dissipation()hooks.BackwardEulerandGeneralizedAlpha/Newmarkto resolve storage throughweakform.get_storage().BackwardEuler.StressEquilibrium.get_storage().ShellBase.area_densityShellBase.rotary_densityBeamProperties.linear_densityBeamProperties.rotary_densityGeneralizedAlphaWeakFormSumdelegate missing attributes/methods to the wrapped stiffness weakform, preserving APIs such asgeneralized_strain_operator()after transient wrapping.Motivation
Previously
GeneralizedAlphafell back toweakform.constitutivelaw.density, which worked for solidStressEquilibriumbut was not general enough for structural weakforms. In particular, plate/shell dynamics need area density and rotary inertia, not raw volumetric density.This PR moves that responsibility to the weakform/constitutive-law layer, where the correct physical storage terms can be defined per formulation.