Remove thin#4087
Merged
Merged
Conversation
lvillen
approved these changes
May 30, 2025
jlledom
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
I am not sure whether this is used anymore. I tracked down the history, and it seems that it was added for some "proxy tests": https://github.com/3scale/system/commit/154af3a533a2536199c6852b48fb8c1d29e3cb9c
And these tests were already removed in https://github.com/3scale/porta/pull/2549/files
Well, now it's causing an issue when trying to upgrade rails to version 7.1:
It looks like the support was added to master branch: macournoyer/thin#399 However, it has not been released yet, the issue is still open: macournoyer/thin#389
Which issue(s) this PR fixes
Verification steps
Special notes for your reviewer: