fix: spawn process metrics as background task#12
Merged
Conversation
init_process_observer runs an infinite loop to collect system metrics, so it must be spawned as a background task instead of being awaited. Also add gzip-tonic feature for OTLP compression support. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
telemetry を有効にするとサーバーが起動しない問題を修正。
opentelemetry_system_metrics::init_process_observer()は内部で無限ループを持ち、システムメトリクスを継続的に収集するバックグラウンドタスクとして設計されている。ライブラリ更新で.awaitを追加したことで無限ループが実行されるようになり、サーバー起動がブロックされていた。tokio::spawnでバックグラウンドタスクとして実行するように修正。また、OTLP gzip 圧縮に必要なgzip-tonicfeature を追加。