⚡ [optimize MicrotubuleTorus rendering with InstancedMesh]#30
⚡ [optimize MicrotubuleTorus rendering with InstancedMesh]#30jason420247 wants to merge 1 commit intomasterfrom
Conversation
Replaced individual mesh components with InstancedMesh to reduce draw calls from 1080 to 2 for the toruses. Used a reusable Object3D for efficient matrix updates in the animation loop and followed library conventions for React Three Fiber. Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The optimization implemented
MicrotubuleTorusto useTHREE.InstancedMeshfor rendering.instancedMeshcomponent.THREE.Object3Dinstance in theuseFrameloop for matrix updates.offsetprop is correctly used in the angle calculation.🎯 Why: The performance problem it solves
📊 Measured Improvement:
Object3D, reducing garbage collection pressure.InstancedMeshnodes.PR created automatically by Jules for task 14928936104551388551 started by @jason420247