Skip to content

⚡ [optimize MicrotubuleTorus rendering with InstancedMesh]#30

Open
jason420247 wants to merge 1 commit intomasterfrom
optimize-microtubule-torus-instanced-mesh-14928936104551388551
Open

⚡ [optimize MicrotubuleTorus rendering with InstancedMesh]#30
jason420247 wants to merge 1 commit intomasterfrom
optimize-microtubule-torus-instanced-mesh-14928936104551388551

Conversation

@jason420247
Copy link
Copy Markdown
Collaborator

💡 What: The optimization implemented

  • Refactored MicrotubuleTorus to use THREE.InstancedMesh for rendering.
  • Replaced individual mesh mapping with a single instancedMesh component.
  • Used a reusable THREE.Object3D instance in the useFrame loop for matrix updates.
  • Ensured the offset prop is correctly used in the angle calculation.

🎯 Why: The performance problem it solves

  • Rendering 1080 individual meshes (360 + 720 from two torus instances) results in 1080 draw calls per frame, which is extremely expensive for the GPU.
  • Individual mesh creation and management in React increases scene graph complexity and memory overhead.

📊 Measured Improvement:

  • Theoretical Improvement: Reduced draw calls from 1080 to 2 for the toruses in the scene.
  • Memory Efficiency: Eliminated per-frame object allocations for matrix updates by using a reusable Object3D, reducing garbage collection pressure.
  • Scene Graph: Simplified the scene graph by replacing 1080 mesh nodes with 2 InstancedMesh nodes.

PR created automatically by Jules for task 14928936104551388551 started by @jason420247

Replaced individual mesh components with InstancedMesh to reduce draw calls from 1080 to 2 for the toruses. Used a reusable Object3D for efficient matrix updates in the animation loop and followed library conventions for React Three Fiber.

Co-authored-by: jason420247 <44763042+jason420247@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant