feat!: add null to return type of serialize()#1355
Open
CatBraaain wants to merge 1 commit into47ng:nextfrom
Open
feat!: add null to return type of serialize()#1355CatBraaain wants to merge 1 commit into47ng:nextfrom
CatBraaain wants to merge 1 commit into47ng:nextfrom
Conversation
|
@CatBraaain is attempting to deploy a commit to the 47ng Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
This seems like a useful addition, but the widening of the return type for I'll keep this one here for the v3 release line. |
80781e9 to
67c20c4
Compare
67c20c4 to
9f8cfb2
Compare
Author
|
Thanks for taking a look. I've pushed new commit fixes the type errors and formatting issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
serialize()function to returnnullto support clearing the query parameter, similar touseQueryState.Background
In
useQueryState,nullconsistently represents the absence of a query parameter:nullif the key is not present in the URL.nullto the setter removes the key from the query string.ref:
Example
This change enables parsers to conditionally omit values from the URL. For example, a parser could return
nullfor certain values to keepthe URL clean:
When 0 is set, the parameter will be cleared from the URL instead of showing ?key=0.