Skip to content

chore: allow finalize to comment on related discussions#1442

Draft
franky47 wants to merge 3 commits into
nextfrom
chore/finalize-comment-on-discussions
Draft

chore: allow finalize to comment on related discussions#1442
franky47 wants to merge 3 commits into
nextfrom
chore/finalize-comment-on-discussions

Conversation

@franky47

@franky47 franky47 commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

In some cases I was bitten by semantic-release's inability to interpret closing references for discussions, not to close the discussion itself, but at least to be able to post a notification there when a release was made.

Don't mind the self-review thing, I haven't gone insane, I'm playing with loops to let an agent address my self-review as I post it.

@vercel

vercel Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nuqs Ready Ready Preview, Comment Jun 19, 2026 8:00am

@coderabbitai

coderabbitai Bot commented Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 90268c6e-fccf-4fa6-8094-8fcd75d06f4f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@franky47 franky47 added the internal Internal issues & discussions label Jun 18, 2026
@franky47 franky47 added this to the 🪵 Backlog milestone Jun 18, 2026
franky47
franky47 commented Jun 18, 2026
View reviewed changes
Comment thread .github/workflows/release-finalize.yml Outdated
Comment thread packages/scripts/lib/commit-graph.ts Outdated
Comment thread packages/scripts/lib/commit-graph.ts Outdated
Comment thread packages/scripts/lib/commit-graph.ts Outdated
@franky47
chore: accept "Addresses" discussion references
0a678da 
Discussions are addressed, never closed, so "closing reference" was too narrow:
`Addresses #N` (and tenses) now resolves a discussion, and the concept is renamed
"target reference" to match the glossary. Review comments also pared to why-only.
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Caution

Review failed

An error occurred during the review process. Please try again later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal Internal issues & discussions

Projects

None yet

Milestone

🪵 Backlog

Development

Successfully merging this pull request may close these issues.

1 participant

@franky47