Fix Text object position after string updates#8620
Open
2bf wants to merge 1 commit into
Open
Conversation
Author
|
CI note: the failed checks look unrelated to this renderer change. Semaphore fails in
Travis fails earlier in the native C++ loop: This PR only changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #975.
This keeps the Pixi text renderer position in sync after a Text object's string changes.
PIXI.Text.updateText(false)recalculates the rendered text metrics, so the renderer also needs to callupdatePosition()afterward; otherwise a rotated Text object can keep the old center/anchor placement and appear to move as the displayed string changes width.This matches the existing BBText and BitmapText renderer behavior, where text-content updates already refresh positioning.
Validation:
git diff --checkI made the change in a sparse checkout, so I did not run the full GDevelop test suite locally.