Skip to content

Issue#7#16

Open
azalut wants to merge 6 commits into
masterfrom
issue#7
Open

Issue#7#16
azalut wants to merge 6 commits into
masterfrom
issue#7

Conversation

@azalut

@azalut azalut commented Feb 16, 2015

Copy link
Copy Markdown

templating idea can be changed if you have any suggestions
for now: every controller should return template.ftl and in the model an attribute "container" containing path to .ftl file should be added; look at the code, my idea quite self explaining

…o be added as container model attribute in every controller that returns template view

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can not change configuration like that, we need to figure it out how to store that localy

@azalut

azalut commented Feb 16, 2015

Copy link
Copy Markdown
Author

so then should we determine database name, username and password for everyone of us? so everyone would use the same data? btw. forgot to change it back sorry ;)

@gaua

gaua commented Feb 16, 2015

Copy link
Copy Markdown
Contributor

No, we should not. I'm not familiar with spring yet but there have to be way to store local configuration or parameters.

http://stackoverflow.com/questions/22757318/different-property-variable-for-local-and-prod-environment-spring

They call it profiles.

@azalut

azalut commented Feb 16, 2015

Copy link
Copy Markdown
Author

the best idea is to create separated task/issue for that :)

Conflicts:
	src/main/java/net/_4programmers/_4note/controllers/UsersController.java
	src/main/webapp/WEB-INF/views/user.ftl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure it is good idea to surround a main content with jumbotron class :)

@azalut

azalut commented Feb 17, 2015

Copy link
Copy Markdown
Author

yes sure, I will send next commit for a while

@azalut

azalut commented Feb 18, 2015

Copy link
Copy Markdown
Author

should I merge it to the master?

@gaua

gaua commented Feb 19, 2015

Copy link
Copy Markdown
Contributor

If it works fine, go ahead. I'm not sure of bootstrap integration, but we can change it in any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants