fix(docs): show WorkSight logo (broken public/assets symlink)#33
Open
kuyacarlo wants to merge 1 commit into
Open
fix(docs): show WorkSight logo (broken public/assets symlink)#33kuyacarlo wants to merge 1 commit into
kuyacarlo wants to merge 1 commit into
Conversation
website/public/assets was a symlink to the whole @worksight/assets package, so the built site exposed /assets/src/logos/logo.png while the theme and hero asked for /assets/logos/logo.png (404 on Vercel). Copy logos into the expected public path and sync them from packages/assets before every docs build/dev. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/assets/logos/logo.png, butwebsite/public/assetswas a symlink to the entire@worksight/assetspackage, so the file actually lived at/assets/src/logos/logo.png(404 in production).public/assets/logos/copy, synced frompackages/assets/src/logoson everydev/build.Test plan
pnpm --filter @worksight/docs buildwrites.vitepress/dist/assets/logos/logo.pngindex.htmlstill references/assets/logos/logo.pngMade with Cursor