TidyContact: Allow defining what EN page types it can run on#372
Open
StoneMoney wants to merge 2 commits intomainfrom
Open
TidyContact: Allow defining what EN page types it can run on#372StoneMoney wants to merge 2 commits intomainfrom
StoneMoney wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update adds an additional option field
page_typesthat allow client themes to specify what EN page types TidyContact should run on. When a page type is not on this allowlist a "TidyContact is disabled on this page type" is printed via the logger.Expected behaviors:
Test pages, uploaded from a branch with the config set to
["DONATION"]:DONATION Page - https://act.ran.org/page/90802/donate/1?assets=tc-pagetypes-test&debug=log (TC should run)
SUBSCRIBEFORM Page - https://act.ran.org/page/55579/subscribe/1?assets=tc-pagetypes-test&debug=log (TC should not run)
Associated task: https://app.productive.io/2650-4site-interactive-studios-inc/tasks/15508244