fix(test): correct implicit string concatenation in test_ship.py message arrays#163
Open
pankaj-bind wants to merge 1 commit into52North:mainfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a subtle Python test-data bug in tests/test_ship.py where implicit string concatenation ('Error' 'OK' -> 'ErrorOK') caused the message NumPy array to have the wrong number of elements, potentially masking defects in ShipParams-related tests.
Changes:
- Add missing comma in
message = np.array([...])withintest_shipparams_get_element. - Add missing comma in
message = np.array([...])withintest_shipparams_get_single.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
Fixes #162
Changes:
tests/test_ship.py- added missing comma inmessagearray literal (2 occurrences)Further Details:
Summary:
In both
test_shipparams_get_elementandtest_shipparams_get_single, themessagearray was defined as:Python's implicit string concatenation silently merged
'Error'and'OK'into'ErrorOK', producing a 3-element array instead of the intended 4-element array. The tests still passed because the corrupted value round-tripped unchanged throughShipParams, masking the defect.This fix adds the missing comma to restore
['OK', 'OK', 'Error', 'OK']in both locations.Dependencies:
None.
PR Checklist: