Fix: fail when optimiser returns no feasible solution#165
Open
Her0n24 wants to merge 1 commit into52North:mainfrom
Open
Fix: fail when optimiser returns no feasible solution#165Her0n24 wants to merge 1 commit into52North:mainfrom
Her0n24 wants to merge 1 commit into52North:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
This PR addresses https://github.com/52North/WeatherRoutingTool/issues/164
Relates to #29 (closed)
Fixes Issue #164
Changes:
Please list the central functionalities that have been changed:
Summary:
Under certain condition/ constraints (e.g. water_depth), the genetic optimiser can end up with no feasible solution. In that case, the result res.F/ res.X are empty or None.
Behavior before
Genetic.terminate() unconditionally called res.F.argmin(), which could crash with AttributeError as res.F/ res.X were None. This hides the real cause of the error.
Behavior after
Genetic.terminate() detects None in res.F/ res.X and raises a clear RuntimeError explaining no feasible route found and suggesting to relax constraints.
Dependencies:
No new runtime dependencies.
PR Checklist:
In the context of this PR, I: