[test] Clarify and cover orphaned functions distance() and time_diffs() in data_utils.py#169
Open
adity1raut wants to merge 2 commits into52North:mainfrom
Open
[test] Clarify and cover orphaned functions distance() and time_diffs() in data_utils.py#169adity1raut wants to merge 2 commits into52North:mainfrom
adity1raut wants to merge 2 commits into52North:mainfrom
Conversation
…_utils.py Signed-off-by: Aditya Raut <araut7798@gmail.com>
…_utils.py Signed-off-by: Aditya Raut <araut7798@gmail.com>
Collaborator
|
Hi @adity1raut, thank you for your PR. We appreciate the time and effort that was put into it. Please be aware that we require to follow 52 North's CLA guidelines for all PRs and, in particular, fill the 52°North Contributor License Agreement. As long as this has not been filled, I can not assign you to any issues or merge any PRs. Please don't hesitate to contact me in case of related questions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
Relates to discussion [link]
Changes:
Please list the central functionalities that have been changed:
Further Details:
Summary:
Please mention the relevant motivation and context of your changes and shortly describe the behaviour before and after your modifications.
distance()andtime_diffs()in
data_utils.pyare not imported or called anywhere in the mainWRT package (
compare.pyusesimport *but never calls them).# TODO: Where is this function used?comments withproper docstrings that document parameters, return types, and include a
.. warning::noting the functions appear to be unused.TestDistanceandTestTimeDiffs(from the previous PR)act as a regression guard until a removal decision is made.
Dependencies:
Please list new dependencies that are required for this modification.
Changes
WeatherRoutingTool/algorithms/data_utils.py— docstringsfor
distance()andtime_diffs()tests/test_data_utils.py— class docstrings forTestDistanceandTestTimeDiffsupdated to reference the unused statusPR Checklist:
In the context of this PR, I:
Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.