Fix arcsin domain error in get_apparent_wind by clamping to [-1,1]#176
Open
RitikaSen27 wants to merge 1 commit into52North:mainfrom
Open
Fix arcsin domain error in get_apparent_wind by clamping to [-1,1]#176RitikaSen27 wants to merge 1 commit into52North:mainfrom
RitikaSen27 wants to merge 1 commit into52North:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix numerical domain error in
get_apparent_wind()wherenp.arcsin()could receive values outside the valid range[-1, 1].Problem
Due to floating-point rounding,
arg_arcsincan occasionally exceed the valid domain slightly. The current implementation clamps only the upper bound (>1) but does not handle values below-1.This can cause
np.arcsin()to returnNaN, which may propagate into downstream route calculations.Fix
Clamp the argument of
np.arcsin()to the full valid range[-1, 1]while keeping the existing rounding tolerance checks.Impact
Prevents NaN propagation in apparent wind angle calculations and improves numerical stability.
PR Checklist:
In the context of this PR, I:
Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.