[test] Add unit tests for formatting utility functions#177
Open
adity1raut wants to merge 1 commit into52North:mainfrom
Open
[test] Add unit tests for formatting utility functions#177adity1raut wants to merge 1 commit into52North:mainfrom
adity1raut wants to merge 1 commit into52North:mainfrom
Conversation
Signed-off-by: Aditya Raut <araut7798@gmail.com>
Collaborator
|
Hi @adity1raut, thank you for your PR. We appreciate the time and effort that was put into it. In the PR template checklist, please ensure that your changes follow the WRT guidelines for contributors. Then, we will review your PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue / Discussion:
Fixes Issue #XX
Changes:
tests/test_formatting.pySummary:
Before:
WeatherRoutingTool/utils/formatting.pyhad zero test coverage.After: 13 unit tests covering
get_line_string,get_log_step,get_point_from_string, andget_bbox_from_string, grouped intopytest classes. Tests are pure unit tests with no I/O or fixtures needed.
Dependencies:
None.
PR Checklist:
In the context of this PR, I:
Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.