Fix inconsistent coordinate ordering and rename reserved keyword in M…#187
Open
vamshikiran065-jpg wants to merge 1 commit into52North:mainfrom
Open
Fix inconsistent coordinate ordering and rename reserved keyword in M…#187vamshikiran065-jpg wants to merge 1 commit into52North:mainfrom
vamshikiran065-jpg wants to merge 1 commit into52North:mainfrom
Conversation
…ap class This update fixes two issues in the Map class: Inconsistent coordinate ordering The constructor initializes coordinates in the order (lat1, lon1, lat2, lon2), but get_var_tuple() returned them as (lat1, lat2, lon1, lon2). This inconsistency could lead to incorrect usage of map bounds. The tuple order has been corrected to match the constructor. Use of reserved keyword (type) The parameter type in the extend_variable method shadows Python’s built-in type. It has been renamed to mode to improve code clarity and avoid potential issues. These changes improve code consistency, readability, and maintainability without altering the core functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ap class
This update fixes two issues in the Map class:
Inconsistent coordinate ordering
The constructor initializes coordinates in the order (lat1, lon1, lat2, lon2), but get_var_tuple() returned them as (lat1, lat2, lon1, lon2). This inconsistency could lead to incorrect usage of map bounds. The tuple order has been corrected to match the constructor. Use of reserved keyword (type)
The parameter type in the extend_variable method shadows Python’s built-in type. It has been renamed to mode to improve code clarity and avoid potential issues.
These changes improve code consistency, readability, and maintainability without altering the core functionality.
Related Issue / Discussion:
Please delete the option which is not relevant.
Fixes Issue #XX
Relates to discussion [link]
Changes:
Please list the central functionalities that have been changed:
Further Details:
Summary:
Please mention the relevant motivation and context of your changes and shortly describe the behaviour before and after your modifications.
Dependencies:
Please list new dependencies that are required for this modification.
PR Checklist:
In the context of this PR, I:
Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.