Skip to content

Fix inconsistent coordinate ordering and rename reserved keyword in M…#187

Open
vamshikiran065-jpg wants to merge 1 commit into52North:mainfrom
vamshikiran065-jpg:patch-1
Open

Fix inconsistent coordinate ordering and rename reserved keyword in M…#187
vamshikiran065-jpg wants to merge 1 commit into52North:mainfrom
vamshikiran065-jpg:patch-1

Conversation

@vamshikiran065-jpg
Copy link
Copy Markdown

…ap class

This update fixes two issues in the Map class:

Inconsistent coordinate ordering
The constructor initializes coordinates in the order (lat1, lon1, lat2, lon2), but get_var_tuple() returned them as (lat1, lat2, lon1, lon2). This inconsistency could lead to incorrect usage of map bounds. The tuple order has been corrected to match the constructor. Use of reserved keyword (type)
The parameter type in the extend_variable method shadows Python’s built-in type. It has been renamed to mode to improve code clarity and avoid potential issues.

These changes improve code consistency, readability, and maintainability without altering the core functionality.

Related Issue / Discussion:

Please delete the option which is not relevant.

Fixes Issue #XX

Relates to discussion [link]

Changes:

Please list the central functionalities that have been changed:

  • New class / file / …
  • Modified class / file / …

Further Details:

Summary:

Please mention the relevant motivation and context of your changes and shortly describe the behaviour before and after your modifications.

Dependencies:

Please list new dependencies that are required for this modification.

PR Checklist:

In the context of this PR, I:

Please consider that PRs which do not meet the requirements specified in the checklist will not be evaluated. Also, PRs with no activities will be closed after a reasonable amount of time.

…ap class

This update fixes two issues in the Map class:

Inconsistent coordinate ordering
The constructor initializes coordinates in the order (lat1, lon1, lat2, lon2), but get_var_tuple() returned them as (lat1, lat2, lon1, lon2). This inconsistency could lead to incorrect usage of map bounds. The tuple order has been corrected to match the constructor.
Use of reserved keyword (type)
The parameter type in the extend_variable method shadows Python’s built-in type. It has been renamed to mode to improve code clarity and avoid potential issues.

These changes improve code consistency, readability, and maintainability without altering the core functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant