Fix weather unit tests for get_u and get_v#191
Open
SrijaVuppula wants to merge 1 commit into52North:mainfrom
Open
Fix weather unit tests for get_u and get_v#191SrijaVuppula wants to merge 1 commit into52North:mainfrom
SrijaVuppula wants to merge 1 commit into52North:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the weather tests for
get_uandget_vso they are actually collected and checked against the correct expected values.Changes
get_u->test_get_uget_v->test_get_vsqrt(2) / 2u_restov_resVerification
Ran:
./venv/bin/pytest tests/test_weather.py -q # Result: 12 passedAlso ran:
./.venv/bin/pytest tests/test_utils.py tests/test_weather.py -q # Result: 39 passedNotes
Before this change,
get_uandget_vdid not start withtest_, so pytest would not collect them as tests.