Skip to content

Increase the timeout minutes#49

Merged
5ouma merged 1 commit intomainfrom
ci-pre-commit-timeout
Mar 29, 2026
Merged

Increase the timeout minutes#49
5ouma merged 1 commit intomainfrom
ci-pre-commit-timeout

Conversation

@5ouma
Copy link
Copy Markdown
Owner

@5ouma 5ouma commented Mar 29, 2026

⚠️ Issue

close #


✏️ Description

It's too short to download all hooks.


It's too short to download all hooks.
Copilot AI review requested due to automatic review settings March 29, 2026 07:51
@github-actions github-actions bot added the 🎽 CI Changes to CI configuration files and scripts label Mar 29, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases the GitHub Actions job timeout for the pre-commit workflow to avoid failures when downloading/installing all pre-commit hooks during CI runs.

Changes:

  • Increase timeout-minutes for the pre-commit job from 5 to 10 minutes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

Walkthrough

The pre-commit GitHub Actions workflow job's execution timeout is increased from 5 minutes to 10 minutes by updating the timeout-minutes configuration value. No other workflow steps, logic, or configuration settings are modified.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/pre-commit.yml
Increased pre-commit job timeout limit from 5 to 10 minutes via timeout-minutes parameter.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Increase the timeout minutes' directly describes the main change in the pull request, which is increasing the timeout limit in the pre-commit GitHub Actions workflow.
Description check ✅ Passed The description explains the rationale for the change, noting that 'it's too short to download all hooks,' which is directly related to the timeout increase in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci-pre-commit-timeout

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
.github/workflows/pre-commit.yml (1)

15-15: LGTM! Timeout increase is appropriate.

The change from 5 to 10 minutes addresses the immediate issue with hook downloads timing out. The new value is reasonable for a pre-commit CI workflow.


Optional: Consider investigating root cause and adding caching.

While increasing the timeout solves the immediate problem, you might want to explore why hook downloads take >5 minutes:

  1. Add caching to speed up subsequent runs and reduce download times:
steps:
  - name: 📦 Cache pre-commit hooks
    uses: actions/cache@v4
    with:
      path: ~/.cache/pre-commit
      key: pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}
  1. Investigate hook performance: Review which hooks take the longest to download and whether any can be optimized or removed.

This would make your CI faster and more resilient to network issues.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/pre-commit.yml at line 15, The workflow timeout was
increased from 5 to 10 minutes to prevent hook download timeouts; keep that
change and optionally add a caching step to speed pre-commit hook downloads by
using actions/cache@v4 to cache ~/.cache/pre-commit with a key like
pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}, and also inspect which
pre-commit hooks are slow in .pre-commit-config.yaml to consider optimizing or
removing them.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In @.github/workflows/pre-commit.yml:
- Line 15: The workflow timeout was increased from 5 to 10 minutes to prevent
hook download timeouts; keep that change and optionally add a caching step to
speed pre-commit hook downloads by using actions/cache@v4 to cache
~/.cache/pre-commit with a key like pre-commit-${{
hashFiles('.pre-commit-config.yaml') }}, and also inspect which pre-commit hooks
are slow in .pre-commit-config.yaml to consider optimizing or removing them.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ebbb11bd-3628-434c-a653-5ecc8ea0c086

📥 Commits

Reviewing files that changed from the base of the PR and between e7b66f4 and 73e6c4f.

📒 Files selected for processing (1)
  • .github/workflows/pre-commit.yml

@5ouma 5ouma merged commit f152104 into main Mar 29, 2026
11 checks passed
@5ouma 5ouma deleted the ci-pre-commit-timeout branch March 29, 2026 07:55
@5ouma 5ouma bot mentioned this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🎽 CI Changes to CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants