fix(api): remove duplicate to_dict() in /api/graph/tasks — crashes every request#305
Open
warren618 wants to merge 1 commit into666ghj:mainfrom
Open
fix(api): remove duplicate to_dict() in /api/graph/tasks — crashes every request#305warren618 wants to merge 1 commit into666ghj:mainfrom
warren618 wants to merge 1 commit into666ghj:mainfrom
Conversation
TaskManager.list_tasks() already returns a list of dicts (it calls t.to_dict() internally at task.py:170). The endpoint then called .to_dict() again on these plain dicts, raising AttributeError on every request to GET /api/graph/tasks.
dosubot
bot
added
the
size:XS
mohamedsorour1998
added a commit
to mohamedsorour1998/MiroFish
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #304
TaskManager.list_tasks()already returns dicts. The endpoint called.to_dict()again on plain dicts →AttributeErroron every request.Fix
One line, one file.