fix(simulation): stop Step2 hanging after prepare failures (#335)#336
Open
Yaohua-Leo wants to merge 1 commit into666ghj:mainfrom
Open
fix(simulation): stop Step2 hanging after prepare failures (#335)#336Yaohua-Leo wants to merge 1 commit into666ghj:mainfrom
Yaohua-Leo wants to merge 1 commit into666ghj:mainfrom
Conversation
- fail prepare tasks when entity filtering produces no usable entities - expose realtime failure state and profile progress metadata - stop Step2 polling when realtime status reports a terminal failure - infer coarse entity types for label-less graph nodes used in simulation prep Fixes 666ghj#335
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #335 by making Step2 stop on terminal prepare failures instead of hanging in config polling.
Changes
status,error, andprofiles_generatedin realtime simulation endpoints used by Step2labels, reducing false zero-entity failuresTesting
GET /api/simulation/entities/mirofish_237fddbbfcd44c23now returnsfiltered_count: 20for a graph whose nodes had empty labelssim_fde532d5b129and ran/api/simulation/preparewithentity_types=[DefinitelyMissingType];/api/simulation/prepare/statusnow returnsstatus: failedwith the backend error instead of leaving Step2 in a fake-complete stateGET /api/simulation/sim_0db482d5074d/config/realtimereturnsstatus: failed,generation_stage: failed, and the real error message for the previously stuck caseImpact
Fixes #335